Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/OP-58/Link-NLDS #335

Merged
merged 4 commits into from
Sep 27, 2023
Merged

feature/OP-58/Link-NLDS #335

merged 4 commits into from
Sep 27, 2023

Conversation

remko48
Copy link
Collaborator

@remko48 remko48 commented Sep 27, 2023

No description provided.

Copy link
Contributor

@lencodes lencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes @remko48 looks a lot better than that it did.

I've left some inline comments.

Also, I see we're adding quite a few classes in multiple files which are doing the same thing (.icon, .link, .linkText). Especially the .icon` we're setting 49 times!

I think what Frameless does in these instances is create a static className, e.g. "link--icon". And then set the required styling somewhere in a global file. This way we only need to set the css rule once (making it much easier to change in the future).

Another possible solution could be to create a wrapper component around this link, which accepts some props (e.g. if we send a icon, the spacing of the icon and label will be handled in the component itself).

pwa/src/components/categoryCard/CategoryCard.tsx Outdated Show resolved Hide resolved
pwa/src/components/componentCard/ComponentCard.tsx Outdated Show resolved Hide resolved
pwa/src/services/getStatusColor.ts Outdated Show resolved Hide resolved
@remko48 remko48 requested a review from lencodes September 27, 2023 15:09
@remko48 remko48 merged commit e75fa6d into development Sep 27, 2023
2 checks passed
@remko48 remko48 deleted the feature/OP-58/Link-NLDS branch September 27, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants